Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement standardized error message output including the stacktrace #1344

Open
5 tasks
tkol2022 opened this issue Sep 30, 2024 · 1 comment
Open
5 tasks
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@tkol2022
Copy link
Collaborator

💡 Summary

Recently we analyzed how to modify ScubaGear to ensure that error message print statements are standardized and that they include the stacktrace. We also had problems that in some instances the stacktrace was wrong so that needs to be addressed too. Issue #1005 presents a solution with some sample code. The purpose of this issue is to formally incorporate those enhancements into ScubaGear.

Implementation notes

Conditions the code must satisfy:

  • Make sure error messages print the stack trace so that we can troubleshoot when problems occur.
  • Make sure the stack trace indicates the correct line where the error occurred. See example in comment below where the catch block inside the Invoke-ProviderList prints the wrong source lines.
  • Make sure the error handling logic correctly aborts execution under export provider failures. For example, right now the orchestrator continues to run additional logic if Export-AADProvider fails, which might not make sense.
@tkol2022 tkol2022 added the enhancement This issue or pull request will add new or improve existing functionality label Sep 30, 2024
@tkol2022 tkol2022 added this to the Kraken milestone Sep 30, 2024
@tkol2022
Copy link
Collaborator Author

tkol2022 commented Oct 1, 2024

At the stand-up meeting on 9/30 we received some feedback from the dev team that creating a new module to house the error message handling is the preferred option instead of putting the new function into an existing module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants