Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak link colors for increased contrast #1349

Open
2 tasks
adhilto opened this issue Oct 1, 2024 · 0 comments
Open
2 tasks

Tweak link colors for increased contrast #1349

adhilto opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented Oct 1, 2024

💡 Summary

Tweak the report link colors for increased contrast.

Motivation and context

This AAD disclaimer at the top in dark mode is the most problematic IMO. I can't even read it without highlighting it. At which point a typo ("file file") typo becomes evident which might make sense to fix with this issue as well.
image

The light mode visited link color might benefit from being darker for more contrast. On the left is the current color, on the right is an example with more contrast.
image

Same thing for the unvisited link color:
image

Implementation notes

The alternate colors used in the above examples (not that we need to use these specifically):

  • Visited: #5b7844
  • Unvisited: #006086

Acceptance criteria

  • Links all have appropriate levels of contrast
  • "file file" typo has been fixed
@adhilto adhilto added the enhancement This issue or pull request will add new or improve existing functionality label Oct 1, 2024
@schrolla schrolla added this to the Kraken milestone Oct 14, 2024
@adhilto adhilto assigned ehaines1 and unassigned adhilto Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants