Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML elements from ScubaResults.json #1290

Open
2 tasks
adhilto opened this issue Aug 26, 2024 · 0 comments · May be fixed by #1384
Open
2 tasks

Remove HTML elements from ScubaResults.json #1290

adhilto opened this issue Aug 26, 2024 · 0 comments · May be fixed by #1384
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented Aug 26, 2024

💡 Summary

#1281 adds a new function, Format-PlainText that removes the HTML elements from the control statements / report details that don't make sense to include in a csv file. Call this same function (or a similar one) to remove elements that don't make sense to include in the json.

Motivation and context

Not all elements prepared for the HTML reports make sense to include in the json version. For example, the "View all CA policies" links in the AAD report don't make sense to include in the json report as that link is specific to the AAD HTML report and is broken out of context.

Implementation notes

Recommend starting with the Format-PlainText function, tweak or make a new one as needed.

Acceptance criteria

  • The HTML elements ScubaGear add to the HTML report for the baseline statements have been replaced
  • The HTML elements ScubaGear add to the HTML report for the report details have been replaced
@adhilto adhilto added the enhancement This issue or pull request will add new or improve existing functionality label Aug 26, 2024
@schrolla schrolla added this to the Kraken milestone Sep 9, 2024
@ehaines1 ehaines1 linked a pull request Oct 29, 2024 that will close this issue
20 tasks
@ehaines1 ehaines1 linked a pull request Oct 29, 2024 that will close this issue
20 tasks
@ehaines1 ehaines1 assigned adhilto and schrolla and unassigned adhilto and schrolla Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@ehaines1 @adhilto @schrolla and others