Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure cargo to use the sparse protocol for registry access #38

Open
1 task
mcdonnnj opened this issue Feb 21, 2023 · 0 comments · May be fixed by #149
Open
1 task

Configure cargo to use the sparse protocol for registry access #38

mcdonnnj opened this issue Feb 21, 2023 · 0 comments · May be fixed by #149
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

💡 Summary

We should configure Cargo to use the sparse protocol in the Docker image.

Motivation and context

We currently install the Rust tool-chain (including Cargo) to support building the cryptography package for image platforms that do not have a pre-built wheel available. We currently must configure Cargo to use the git command line instead of the internal [libgit2] client due to failures observed. When the sparse protocol is available we should switch to that as it is expected to be more performant in CI situations (like this) in addition to the other, less relevant, improvements.

Implementation notes

The Cargo configuration file we copy into the image should be updated to direct Cargo to use the sparse protocol for index retrieval. Support is not expected until the Rust 1.68 release per rust-lang/cargo#9069 (comment).

Acceptance criteria

  • Cargo is configured to use the sparse protocol for index retrieval
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Feb 21, 2023
mcdonnnj added a commit that referenced this issue May 23, 2024
@mcdonnnj
Remove the custom Cargo configuration
b5ff78e 
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo
1.64.0 to 1.71.1. This takes us past Rust 1.68 (since Cargo uses the
same version) which introduced sparse registries and as a result this
should resolve #38.
mcdonnnj added a commit that referenced this issue Jun 24, 2024
@mcdonnnj
Remove the custom Cargo configuration
661e508 
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo
1.64.0 to 1.71.1. This takes us past Rust 1.68 (since Cargo uses the
same version) which introduced sparse registries and as a result this
should resolve #38.
mcdonnnj added a commit that referenced this issue Aug 26, 2024
@mcdonnnj
Remove the custom Cargo configuration
498b65a 
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo
1.64.0 to 1.71.1. This takes us past Rust 1.68 (since Cargo uses the
same version) which introduced sparse registries and as a result this
should resolve #38.
mcdonnnj added a commit that referenced this issue Aug 27, 2024
@mcdonnnj
Remove the custom Cargo configuration
7f2c235 
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo
1.64.0 to 1.71.1. This takes us past Rust 1.68 (since Cargo uses the
same version) which introduced sparse registries and as a result this
should resolve #38.
mcdonnnj added a commit that referenced this issue Aug 28, 2024
@mcdonnnj
Remove the custom Cargo configuration
f48ed81 
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo
1.64.0 to 1.71.1. This takes us past 1.68, which introduced sparse
registries, and 1.70, which made `sparse` the default protocol to use
with crates.io (the default registry). This resolves #38, and based on
testing it also resolves #32.
mcdonnnj added a commit that referenced this issue Aug 29, 2024
@mcdonnnj
Remove the custom Cargo configuration
19dcaeb 
In the move from Alpine Linux 3.17 to 3.18 we also moved from Cargo
1.64.0 to 1.71.1. This takes us past 1.68, which introduced sparse
registries, and 1.70, which made `sparse` the default protocol to use
with crates.io (the default registry). This resolves #38, and based on
testing it also resolves #32.
@mcdonnnj mcdonnnj linked a pull request Aug 29, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the custom Cargo configuration cisagov/code-gov-update
1 participant
@mcdonnnj