Move cyhy user creation to AMI build time
#640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an Ansible playbook and imports it in the main playbook used to build the AMIs.
Remove the cloud-init configuration file and all cloudinit configuration parts for `cyhy` user creation.
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Mar 28, 2023
dav3r
approved these changes
Mar 28, 2023
We prefer to sort task keys alphabetically and the authorized key setup was not in compliance. Co-authored-by: dav3r <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request moves creation of the
cyhyuser to AMI build time from being part of individual instance cloud-init configurations.💭 Motivation and context
This change moves user creation to AMI build time to provide a better guarantee that the
cyhyuser exists before any Ansible provisioners are run against an instance during deployment. It will also allow the option for cyhy-specific Ansible roles to expect the existence of thecyhyuser as part of their logic. As a bonus this reduces complexity by removing this element of the individual cloud-init configurations for instances that need this user.🧪 Testing
Automated tests pass. I used this branch in my test environment and verified that the
cyhyuser existed and that SSH access worked as expected.✅ Pre-approval checklist