Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Rework gh base selection when supported by gh #17

Open
felddy opened this issue May 18, 2022 · 0 comments
Open

TODO: Rework gh base selection when supported by gh #17

felddy opened this issue May 18, 2022 · 0 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@felddy
Copy link
Member

felddy commented May 18, 2022

When gh adds support for setting the base repo rework these lines to use that new functionality.
See:

gh-skeleton/gh-skeleton

Lines 113 to 116 in 244bda9

log_info "Setting base repository for pull request and issue creation."
# TODO: Replace with a gh command when it is implemented.
# See: https://github.com/cli/cli/issues/2300
git -C "${dest_repo}" config --local --add "remote.origin.gh-resolved" "base"

Originally posted by @dav3r in #16 (review)

@felddy felddy added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

1 participant