Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On the User table a portfolio can't be added without a portfolio role #2519

Closed
abroddrick opened this issue Jul 31, 2024 · 2 comments · Fixed by #2566
Closed

On the User table a portfolio can't be added without a portfolio role #2519

abroddrick opened this issue Jul 31, 2024 · 2 comments · Fixed by #2566
Assignees
@dave-kennedy-ecs
Labels
dev Feature: 🏢 Org Model
Milestone
b | Org Model m3 ...

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jul 31, 2024 •
edited
Loading

Issue description

When saving a User object, we want to make sure we can't have the scenario where a user has a portfolio but no role. Our goal is to display the roles for each user with the bare minimum being an org member. Likewise, ti wouldn't make sense to have a portfolio role with no portfolio in the object.

Acceptance criteria

  • On the User table, portfolio roles and portfolio must be both filled in or both empty when a user object is saved, otherwise an error occurs
    • for instance, you cannot have portfolio roles filled in but leave portfolio blank. Likewise, if portfolio field is filled in roles is blank then a validation error occurs.

Additional context

No response

Links to other issues

blocks #2402
@abroddrick abroddrick added the dev label Jul 31, 2024
@abroddrick abroddrick moved this from 👶 New to 🍦 Backlog in .gov Product Board Jul 31, 2024
@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Aug 5, 2024
@vickyszuchin vickyszuchin moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Aug 6, 2024
@dave-kennedy-ecs dave-kennedy-ecs self-assigned this Aug 12, 2024
@dave-kennedy-ecs dave-kennedy-ecs moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Aug 12, 2024
@dave-kennedy-ecs dave-kennedy-ecs mentioned this issue Aug 12, 2024
Merged
46 tasks
@dave-kennedy-ecs dave-kennedy-ecs moved this from 🏗 In progress to 👀 In review in .gov Product Board Aug 12, 2024
@abroddrick abroddrick added design-review Needs design review Feature: 🏢 Org Model and removed design-review Needs design review labels Aug 12, 2024
@github-actions GitHub Actions
Copy link

cc/ @Katherine-Osos — adding you to this design-review issue!

@abroddrick
Copy link
Contributor Author

Ignore the ping Katherine! I selected the wrong tag!

dave-kennedy-ecs added a commit that referenced this issue Aug 13, 2024
@dave-kennedy-ecs
Merge pull request #2566 from cisagov/dk/2519-user-table-portfolio
48efde9 
Issue #2519: On User table, portfolio cannot be added without role or permission
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dave-kennedy-ecs dave-kennedy-ecs

Labels
dev Feature: 🏢 Org Model
Projects
.gov Product Board
Archived in project
Milestone
b | Org Model m3 - Analyst Experience
2 participants
@abroddrick @dave-kennedy-ecs