Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Send email that announces when domain information has changed #2307

Closed
13 tasks
Katherine-Osos opened this issue Jun 12, 2024 · 11 comments · Fixed by #2827
Closed
13 tasks

Dev: Send email that announces when domain information has changed #2307

Katherine-Osos opened this issue Jun 12, 2024 · 11 comments · Fixed by #2827
Assignees
Labels
🔔 Notifications carryover Carryover from a previous sprint dev

Comments

@Katherine-Osos
Copy link
Contributor

Katherine-Osos commented Jun 12, 2024

Issue description

We need to send domain managers an announcement when edits have been made to domain information. This includes updates to:

  • org name and mailing address
  • senior official
  • nameservers
  • DNSSEC
  • security contact

All domain managers for the domain should be CC'd on the email (including the person who made the change).

Acceptance criteria

  • When a user updates domain information on the following pages via the registrar, an email is sent to all managers for that domain (including the person who made the update):

  • The email should use content outlined in this document.

  • Only send email notifications for DNS changes that take place AFTER the initial DNS name servers are added to the domain. i.e. do not send an email for DNS entries added from the "DNS Needed" state.

  • Domain managers should be CC'd on the same email rather than sending separate emails.

  • Domain managers page is updated to reflect content changes defined in this document.

Additional context

No response

Links to other issues

@Katherine-Osos
Copy link
Contributor Author

The related content ticket (#2196) noted that a separate dev ticket should be created for the org model. That doesn't seem necessary; confirm during refinement.

@abroddrick
Copy link
Contributor

This one raises a yellow warning flag. We have imported stable dbs into other sandboxes, which includes domain management. If this was added now, changing anything on those domain infos would notify real humans. We need a ticket before this to update documentation with deleting user domain roles after importing from stable (we can't just choose not to import that one table unfortunetly), then probably want to edit the test banner to show if email sending is turned on.

@abroddrick
Copy link
Contributor

Also is this meant to block the design review of just the graphics? Could this be it's own milestone?

@abroddrick
Copy link
Contributor

Hey @Katherine-Osos can you confirm two things: 1.) this will be released for non-org model users as well and 2.) If an analyst or superuser changes something, it will not result in an email.

@Katherine-Osos
Copy link
Contributor Author

Katherine-Osos commented Aug 17, 2024

@abroddrick Correct on both things! 1) Will apply to non-org (i.e. this ticket can be released before org model is launched) and 2) we should not send emails when the update is initiated via the admin.

cc: @h-m-f-t # 2 relates to the discussion we had this morning, so just tagging you for visibility.

@vickyszuchin
Copy link

Per refinement meeting, @abroddrick will create a dev ticket that will be scoped to preparation for this ticket.

@vickyszuchin vickyszuchin moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Aug 29, 2024
@Matt-Spence Matt-Spence self-assigned this Aug 29, 2024
@abroddrick abroddrick removed the blocked label Sep 3, 2024
@vickyszuchin vickyszuchin moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Sep 4, 2024
@Matt-Spence Matt-Spence moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Sep 4, 2024
@Matt-Spence
Copy link
Contributor

Matt-Spence commented Sep 16, 2024

@Katherine-Osos @abroddrick Three questions:

  1. How do we want to handle interactions between multi-recipient emails (emails to more than one person) and the email whitelist? Like, if we have several domain managers, should we block sending the email if any of them are not-whitelisted, or just filter the addresses and only send to the whitelisted ones?
  2. Do we want any kind of indication to the user if email sending fails? Perhaps usng the messages API like we do for success/failure of updates?
  3. Do we want to CC extra domain managers, or just put them all in the to: section? Both will create valid emails. If the former, how should we select which emails to set as the to: address and the CC: address?

@abroddrick
Copy link
Contributor

abroddrick commented Sep 16, 2024

Great questions:

  1. Don't block, just only email the whitelisted ones
  2. We do currently have success/failure messages for domain info changes so up to @Katherine-Osos on if their content should change with the addition of emails. I do think at the very least we should mention on the page that emails will be sent to other domain managers for any changes.
  3. I believe the intent here was to have no "To" recipient and just have them all CC'd. To address shouldn't be a required field and just cc should work. Some reference

@Katherine-Osos
Copy link
Contributor Author

@Matt-Spence For your second question ... no need to display error messaging if the email fails. It's simply a receipt and not the primary action.

That being said, to Alysia's point, let's add a bit of messaging about this update to the Domain Managers page.
I DM'd you the new text for that page.

@vickyszuchin
Copy link

vickyszuchin commented Oct 7, 2024

Moving this ticket from sprint 54 to the current sprint (sprint 55). cc: @abroddrick @lizpearl

@vickyszuchin
Copy link

Moving this ticket from sprint 55 to the current sprint (sprint 56). cc: @abroddrick @lizpearl

Matt-Spence added a commit that referenced this issue Oct 21, 2024
#2307: send notification emails on changes to domain - [MS]
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔔 Notifications carryover Carryover from a previous sprint dev
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants