Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DRAFT) Add @property to portfolio related fields in Domain Requests #2852

Open
13 tasks
CocoByte opened this issue Sep 25, 2024 · 3 comments
Open
13 tasks

(DRAFT) Add @property to portfolio related fields in Domain Requests #2852

CocoByte opened this issue Sep 25, 2024 · 3 comments

Comments

@CocoByte
Copy link
Contributor

CocoByte commented Sep 25, 2024

Issue description

With the introduction of org model, certain fields stored in Domain Requests are now stored in Portfolios. In order to avoid duplication of data, Org Model domain requests should not directly store data already present in their associated portfolio. Instead, we will add @property to the relevant fields so that Org Model domain requests reference Portfolio data.

Acceptance criteria

Update the following Domain Request fields to point to equivalent Portfolio fields if the Domain Request is an org model request.

  • organization_name
  • generic_org_type (called "organization_type" in Portfolio)
  • notes
  • federal_agency
  • federal_type
  • senior_official
  • address_line1
  • address_line2
  • city
  • state_territory
  • zipcode
  • urbanization
  • security_contact_email

Additional context

No response

Links to other issues

No response

@CocoByte CocoByte changed the title (DRAFT) DB properties for org-model Domain Requests (DRAFT) Add @Parameter to fields in Domain Requests Sep 26, 2024
@CocoByte CocoByte changed the title (DRAFT) Add @Parameter to fields in Domain Requests (DRAFT) Add @Parameter to portfolio related fields in Domain Requests Sep 26, 2024
@CocoByte
Copy link
Contributor Author

CocoByte commented Sep 26, 2024

@abroddrick I am unsure if "Notes" should also have @-parameter for it. Also, I am ignoring some fields like "about_your_organization" as well as fields related to federal_type (such as "federally_recognized_tribe" and "state_recognized_tribe") since these do not show up in portfolios...do you have any thoughts on how we should approach these non-portfolio fields?

@abroddrick abroddrick changed the title (DRAFT) Add @Parameter to portfolio related fields in Domain Requests (DRAFT) Add @property to portfolio related fields in Domain Requests Sep 26, 2024
@h-m-f-t
Copy link
Member

h-m-f-t commented Sep 30, 2024

I think we'll want to have tribal information as part of the org model eventually (i.e., it maybe should have @ parameter) but I defer to engineering on the need for this now.

@h-m-f-t
Copy link
Member

h-m-f-t commented Sep 30, 2024

Adding refinement simply because it's still marked draft and we've moving it out of new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🍦 Backlog
Development

No branches or pull requests

2 participants