Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django admin: Federal agency page updates #2868

Open
4 tasks
zandercymatics opened this issue Sep 30, 2024 · 1 comment
Open
4 tasks

Django admin: Federal agency page updates #2868

zandercymatics opened this issue Sep 30, 2024 · 1 comment

Comments

@zandercymatics
Copy link
Contributor

zandercymatics commented Sep 30, 2024

Issue description

The federal agency page in django admin needs a few QOL and consistency updates to better reflect our established patterns. More specifically, we should change the "agency" and "federal type" fields.

Acceptance criteria

  • Update "agency" field to read as "Federal agency" on the Federal Agency page to match other instances of that field.
    • Ensure that this change is also present on the table view.
  • Update the "agency" field to be required
  • Update the "federal_type" field to be required
  • Remove helper text underneath the "Federal agency" field.

Additional context

Regarding AC #1: Note that the name on the frontend doesn't always need to match what is on the backend. If it makes more sense, one approach may be to use verbose_name rather than renaming the field in the DB. However you can change this if it is deemed necessary - but be aware of the refactor that it will entail.

Links to other issues

No response

@h-m-f-t
Copy link
Member

h-m-f-t commented Sep 30, 2024

@zandercymatics would this affect the data in current-full/federal? If so, how? (Added refinement label)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🍦 Backlog
Development

No branches or pull requests

3 participants