Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit requirement for community.docker from the Molecule requirements #195

Open
1 task
mcdonnnj opened this issue May 29, 2024 · 2 comments
Open
1 task

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented May 29, 2024

💡 Summary

This requirement is added in #196 and should be removed when no longer needed.

Motivation and context

This requirement is a way for us to a get a version of the community.docker collection that is compatible with requests version 2.32.0 and newer. The version available from the latest ansible release is not new enough and we are still waiting on the merge of ansible-community/molecule-plugins#257 to force molecule-plugins to require a compatible version for the Docker driver. We would also be able to skirt around this issue with the release of Ansible 9.7 next month (June of 2024) as it should contain the newer version of the community.docker collection.

Acceptance criteria

How do we know when this work is done?

  • Revert changes to the molecule/default/requirements.yml file.
@jsf9k
Copy link
Member

jsf9k commented Jun 17, 2024

docker/docker-py#3257 has been merged and a new version has been released. I think this means we can now revert or modify the requirement added in #196.

@mcdonnnj
Copy link
Member Author

docker/docker-py#3257 has been merged and a new version has been released. I think this means we can now revert or modify the requirement added in #196.

I'm unclear on what you're saying here. That PR was merged and a new release was cut almost a week before this issue was created. The community.docker project vendors docker-py so we explicitly need the fixes made to this vendored code in 3.10.1 and 3.10.2. The current version of Ansible per our version pinning is 9.6.1, which only has community.docker 3.10.1 (likely because this is an emergency bugfix release for the yanked 9.6.0 release). Theoretically this issue can also be resolved if a newer version of Ansible that we are pinned around includes community.docker >=3.10.2.

cisagovbot pushed a commit that referenced this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants