Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native ARM runners when testing on ARM architecture #214

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Use native ARM runners when testing on ARM architecture #214

wants to merge 2 commits into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 18, 2025 •
edited
Loading

🗣 Description

This pull request:

💭 Motivation and context

  • This provides better and faster testing of ARM architectures than using QEMU emulation.
  • We are no longer emulating ARM under QEMU, so using this GitHub Action no longer causes the runners to run out of resources and crash.

Resolves #211.

🧪 Testing

All automated tests pass. I also verified that the expected platforms are indeed tested via native ARM runners.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Jan 18, 2025
jsf9k added 2 commits January 18, 2025 12:53
@jsf9k
Use native ARM runners when testing on ARM architecture
63c02db 
This provides better and faster testing of ARM architectures than
testing under QEMU emulation.
@jsf9k
Uncomment the GitHubSecurityLab/actions-permissions/monitor@v1 job
b10d648 
We are no longer emulating ARM under QEMU, so using this GitHub Action
no longer causes the runners to run out of resources and crash.
@jsf9k jsf9k force-pushed the improvement/use-native-arm-runners branch from afd5051 to b10d648 Compare January 18, 2025 17:54
@jsf9k jsf9k marked this pull request as ready for review January 18, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: In Progress
Skeleton Maintenance
Status: Review in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHubSecurityLab/actions-permissions/monitor causes test jobs to randomly fail
2 participants
@jsf9k @mcdonnnj