Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project #15

Open
2 tasks
mcdonnnj opened this issue Jun 12, 2023 · 0 comments
Open
2 tasks

Refactor project #15

mcdonnnj opened this issue Jun 12, 2023 · 0 comments
Assignees
Labels
breaking change This issue or pull request involves changes to existing functionality dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use test This issue or pull request adds or otherwise modifies test code

Comments

@mcdonnnj
Copy link
Member

💡 Summary

This project should be refactored for multiple reasons.

Motivation and context

An AWS Lambda just needs to be a single deployable artifact that only needs to support a single Lambda runtime. Given that premise we can pare down the Docker/pipenv configuration to target a single version of Python (corresponding with a supported AWS Lambda Python runtime). This should also allow us to integrate testing of the Python code much more easily.

Implementation notes

  • Reduce the pipenv configurations down to a single configuration targeting a single Python version.
  • Reorganize the directory structure accordingly.
  • Implement support for Python code testing (through pytest).
  • Update the GitHub Actions workflows accordingly.

Acceptance criteria

  • There is only a single deployment artifact created.
  • Python code testing is integrated.
@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file test This issue or pull request adds or otherwise modifies test code labels Jun 12, 2023
@mcdonnnj mcdonnnj self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull request involves changes to existing functionality dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use test This issue or pull request adds or otherwise modifies test code
Projects
Development

No branches or pull requests

1 participant