Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of the configure-aws-credentials GitHub Action #199

Open
1 task
jsf9k opened this issue Dec 2, 2022 · 0 comments
Open
1 task

Update the version of the configure-aws-credentials GitHub Action #199

jsf9k opened this issue Dec 2, 2022 · 0 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use on hold This pull request is awaiting an action or decision to move forward

Comments

@jsf9k
Copy link
Member

jsf9k commented Dec 2, 2022

💡 Summary

If necessary, we should update the version of the aws-actions/configure-aws-credentials GitHub Action.

Motivation and context

We currently use the tag v1, but when doing so we get annoying warning messages in our GitHub Actions logs:

Run aws-actions/configure-aws-credentials@v1

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The warnings have already been fixed upstream, and the fixed code is available in the v1-node16 branch, but the v1 tag has not yet been moved. (This is all detailed in aws-actions/configure-aws-credentials#521. The set-output command is to be disabled on or about May 31, 2023, so if the tag has not been moved by then we should switch to the v1-node16 branch.

Implementation notes

The aws-actions/configure-aws-credentials Action is called in the following workflows:

  • build.yml
  • prerelease.yml
  • release.yml

Acceptance criteria

How do we know when this work is done?

  • The annoying warnings in our GitHub Actions logs are gone.
@jsf9k jsf9k pinned this issue Dec 2, 2022
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use on hold This pull request is awaiting an action or decision to move forward labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use on hold This pull request is awaiting an action or decision to move forward
Projects
Development

No branches or pull requests

1 participant