Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Subscribe request Mode #65

Merged
merged 2 commits into from
Jul 17, 2020
Merged

CLI Subscribe request Mode #65

merged 2 commits into from
Jul 17, 2020

Conversation

remingtonc
Copy link
Contributor

Specify SubscribeRequest.SubscriptionList.Mode from CLI. Previously only did default, usually STREAM. Required for ONCE, etc.

Fixes #64

@remingtonc remingtonc added enhancement New feature or request ergonomics labels Jun 22, 2020
@remingtonc remingtonc requested a review from a team June 22, 2020 17:36
@remingtonc remingtonc self-assigned this Jun 22, 2020
@remingtonc remingtonc requested review from anushramsurat1 and ziausyed and removed request for a team June 22, 2020 17:36
@remingtonc
Copy link
Contributor Author

ping

miott
miott reviewed Jul 14, 2020
View reviewed changes
src/cisco_gnmi/__init__.py
@@ -30,4 +30,4 @@
from .xe import XEClient
from .builder import ClientBuilder

__version__ = "1.0.10"
__version__ = "1.0.11"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought we are at "1.0.11" now so should this be bumped to "12"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging into another branch for collective bump.

@remingtonc remingtonc changed the base branch from master to rel-v1.0.12 July 17, 2020 20:42
@remingtonc remingtonc merged commit fa89ea8 into rel-v1.0.12 Jul 17, 2020
@remingtonc remingtonc deleted the cli-subscribe-mode branch July 17, 2020 20:42
@remingtonc remingtonc mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miott miott miott left review comments

@ziausyed ziausyed ziausyed approved these changes

@anushramsurat1 anushramsurat1 Awaiting requested review from anushramsurat1

Assignees

@remingtonc remingtonc

Labels
enhancement New feature or request ergonomics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Subscribe Mode to CLI
3 participants
@remingtonc @miott @ziausyed