-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsupported unicode characters in two styles #7274
base: master
Are you sure you want to change the base?
Conversation
`journal-of-the-marine-biological-association-of-the-united-kingdom.csl` - From PR citation-style-language#2547, it looks like the original style was cloned from `apa-6th-edition.csl`. The invalid character in `number-of-volumes` was updated to match that journal: `–`. `museum-national-dhistoire-naturelle.csl` - Overwhelmingly, styles use the following within the `genre` macro: ``` <text variable="number" prefix=" No. "/> ``` Only styles with default locale `de-DE` sometimes use ` Nr. `. Fixes citation-style-language#7222
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: journal-of-the-marine-biological-association-of-the-united-kingdom.csl (modified style; unchanged output for sample items)(Hancké et al., 2007; ‘CSL search by example’, 2012) museum-national-dhistoire-naturelle.csl (modified style; unchanged output for sample items)(Hancké et al. 2007; Anonymous 2012) |
@bwiernik - Would you be willing to review this? |
Thanks. The second fix should be |
Co-authored-by: Brenton M. Wiernik <[email protected]>
Thanks for the review and change suggestion @bwiernik . Looks like CI's report stage is failing for several PRs right now, but this is otherwise complete. |
Thanks! I'll merge once CI is fixed |
Fix invalid unicode characters in the following styles:
journal-of-the-marine-biological-association-of-the-united-kingdom.csl
apa-6th-edition.csl
. The invalid character innumber-of-volumes
was updated to match that journal:–
.museum-national-dhistoire-naturelle.csl
"Nº"
was suggested by bwiernik in review.Fixes #7222