Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported unicode characters in two styles #7274

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mdmower
Copy link

@mdmower mdmower commented Oct 21, 2024

Fix invalid unicode characters in the following styles:

journal-of-the-marine-biological-association-of-the-united-kingdom.csl

museum-national-dhistoire-naturelle.csl

  • Replacement "Nº" was suggested by bwiernik in review.

Fixes #7222

`journal-of-the-marine-biological-association-of-the-united-kingdom.csl`

- From PR citation-style-language#2547, it looks like the original style was cloned from
  `apa-6th-edition.csl`. The invalid character in `number-of-volumes`
  was updated to match that journal: `–`.

`museum-national-dhistoire-naturelle.csl`

- Overwhelmingly, styles use the following within the `genre` macro:
  ```
  <text variable="number" prefix=" No. "/>
  ```
  Only styles with default locale `de-DE` sometimes use ` Nr. `.

Fixes citation-style-language#7222
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-the-marine-biological-association-of-the-united-kingdom.csl (modified style; unchanged output for sample items)
(Hancké et al., 2007; ‘CSL search by example’, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012). Available at http://editor.citationstyles.org/searchByExample/ (Accessed 15 December 2012)
Fenner M, Crosas M, Grethe JS, Kennedy D, Hermjakob H, Rocca-Serra P, Durand G, Berjon R, Karcher S, Martone M and Clark T (2019) A data citation roadmap for scholarly data repositories. Scientific Data 6, 28.
Hancké B, Rhodes M and Thatcher M (Eds.) (2007) Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares I (2001) Firms and the welfare state: When, why, and how does social policy matter to employers? In Hall Peter A. and Soskice David (eds.) Varieties of capitalism. The institutional foundations of comparative advantage, pp. 184–213. New York: Oxford University Press.
museum-national-dhistoire-naturelle.csl (modified style; unchanged output for sample items)
(Hancké et al. 2007; Anonymous 2012)
(Mares 2001; Fenner et al. 2019)

Fenner M., Crosas M., Grethe J.S., Kennedy D., Hermjakob H., Rocca-Serra P., Durand G., Berjon R., Karcher S., Martone M. & Clark T. 2019. — A data citation roadmap for scholarly data repositories. Scientific Data 6 (1): 28. https://doi.org/10.1038/s41597-019-0031-8
Mares I. 2001. — Firms and the welfare state: When, why, and how does social policy matter to employers?, in Hall P.A. & Soskice D. (eds.), Varieties of capitalism. The institutional foundations of comparative advantage. New York, Oxford University Press. p. 184–213.
Anonymous 2012. — CSL search by exampleAvailable from http://editor.citationstyles.org/searchByExample/ [accessed 15 December 2012]
Hancké, B., Rhodes, M. & Thatcher, M. (Eds.) 2007. — Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, in . Oxford and New York, Oxford University Press.

@mdmower
Copy link
Author

mdmower commented Jan 20, 2025

@bwiernik - Would you be willing to review this?

@bwiernik
Copy link
Member

Thanks. The second fix should be "N&ordm;"

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 21, 2025
museum-national-dhistoire-naturelle.csl Outdated Show resolved Hide resolved
@mdmower
Copy link
Author

mdmower commented Jan 21, 2025

Thanks for the review and change suggestion @bwiernik . Looks like CI's report stage is failing for several PRs right now, but this is otherwise complete.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 21, 2025
@bwiernik
Copy link
Member

Thanks! I'll merge once CI is fixed

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported unicode characters exist in two styles that can cause issues for some XML parsers
2 participants