APA: Fix multi-creator delimiter (writer/director, guest/host) #7396
+44
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@retorquere @adam3smith Do you know why the CI is failing? |
github-actions
bot
added
the
waiting-for-response-from-contributor
|
What I can find on that error suggests upgrading ruby infra -- I've been out of the ruby game for a long time, but the tests are using 3.0.2, and the current ruby is 3.4. |
|
I'll prep a PR that updates ruby to ~>3.3 and updates gems. Looks like that will work. |
|
Spoke to soon. I can only update to ruby >3.2 once this is fixed: |
|
Are you planning to open a PR on the csl-ruby repo @adam3smith ? |
Oh yes, sorry, I just missed clicking the button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.