Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image resize like done on ep_copy_paste_images #10

Open
Oremountainflorian opened this issue Apr 12, 2020 · 11 comments
Open

Image resize like done on ep_copy_paste_images #10

Oremountainflorian opened this issue Apr 12, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@Oremountainflorian
Copy link

Hey out there,

have you already considered providing the option to resize images as @JohnMcLear did on ep_copy_paste_images?

Here are some infos about that

JohnMcLear/ep_previewimages#14 (comment)

Thank you very much for your engagement! Best wishes, Flo

@Oremountainflorian
Copy link
Author

Update On Firefox/Chrome (at least with Windows) it's possible to resize images by going to the respective line hitting tab (smaller) and shift+tab (larger)

@tiblu
Copy link
Member

tiblu commented May 27, 2020

Yes, we have talked about it, but our organization has 1.5 developers thus it will probably be at the bottom of the priority list.

I will add this to our prioritization.

Also, we welcome pull requests!

@loorm
Copy link
Member

loorm commented Jun 8, 2020

Triage 23. @Oremountainflorian ep_copy_paste_images implementation is styles-only. However, in Citizen OS, we must also be able to generate document files (docx) from EP content. Even if we enabled image resize in EP, the image would still appear full size in docx, thus creating an inconsistent user experience.

The scope of making this change will become very large very quickly for us. Like @tiblu said, we very much welcome pull requests, but it will be an undefined while, before we ourselves get around to implementing image resize. Unless a large number of users start reporting this as an inconvenience.

@KatiVellak
Copy link

Legally reviewed, no additions.

@JohnMcLear JohnMcLear added the enhancement New feature or request label Feb 9, 2021
@JohnMcLear JohnMcLear changed the title [Feature request] Image resize like done on ep_copy_paste_images Image resize like done on ep_copy_paste_images Feb 9, 2021
@loorm
Copy link
Member

loorm commented Sep 3, 2021

@tiblu @ilmartyrk Any changes in the new EP version regarding image resize?

@ghost
Copy link

ghost commented Nov 5, 2021

Any update regarding image resizing , the old version it took full width of page but now it takes only 1/4 of the page :

old version of plugin better preview:
image

the new version:
image

I preferer the old version

@loorm
Copy link
Member

loorm commented Nov 15, 2021

Tagging @anettlinno. Please see most recent community input above.

@anettlinno
Copy link

anettlinno commented Nov 16, 2021

Triage 52. Currently the maximum height of the picture is set on 500 pixels. We will take off the height limit and this should fix this problem.
Est. dev. time 30 min. Sending to development.

The limit is set inside ace.css and it comes from etherpad core styles. We can add the style update inside plugin stylesheet to override this limit

@ilmartyrk ilmartyrk self-assigned this Feb 9, 2022
@ilmartyrk ilmartyrk removed their assignment Feb 10, 2022
@ilmartyrk
Copy link
Member

Removed the height limit from styles, but this initial issue still remains adding resize functionality to images

@anettlinno
Copy link

anettlinno commented Feb 15, 2022

Triage 60. Sending this issue back to In Prep to wait for the decision if we will continue using EP or we change to some other text editor platform. This decision is waiting behind the redesign project.

@BeccaMelhuish
Copy link

@ilmartyrk seems this may now be relevant again (redesign is done and we still use etherpad), but putting in 'later' for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog - Later
Development

No branches or pull requests

8 participants