-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show other file types as download link #5
Comments
I'm not sure I understand this issue @rasos ;/ |
The idea was that this plugin also allows other file types to be uploaded, such as a PDF to be shared. If I add pdf as file type, we get an exception when uploading a pdf:
I understand that for each media type (audio, video) an extra plugin is required. There is none for documents yet (PDF, docx, xlsx etc). |
Oh that wasn't within scope with plugin description as I read it. My apologies if I missed that.. I won't get chance for a few months to look at this but the code is not very readable and maintainable so it should be relatively simple for a developer to add this functionality. |
Comment from so completely unrelated: I doubt that the |
Other file types than images are not shown as download link.
As the sister plugin ep_fileupload has an unresolved cross origin issue redhog/ep_fileupload#24 and is un-usable, it would be nice to extend the functionality by showing a download link for non-image MIME types.
"fileTypes": ["jpeg","jpg","bmp","gif","png","pdf","mp4","ogg","mp3","webm","wav","md","rtf","tex","txt","doc","docx","xls","xlsx","pptx","ods","odt","odp","html","pages","py","zip"],
The text was updated successfully, but these errors were encountered: