Problems with building pg-auto-failover for Debian

[df7cb]

Hi,

following a discussion with @DimCitus I was trying to build pg-auto-failover for Debian (and apt.postgresql.org).

Problem 1:

$ pg_buildext updatecontrol
pg_buildext: error: No current PostgreSQL versions are supported by this package

-> debian/pgversions is missing the final newline (which is required for proper POSIX text files)

Problem 2:

$ origtargz 
W: Paket pg-auto-failover kann nicht gefunden werden.
Trying uscan --download --download-current-version ...
uscan: Newest version of pg-auto-failover on remote site is 1.4.1, specified download version is 1.4.1
uscan warn: In directory ., downloading
  https://github.com/citusdata/pg_auto_failover/releases/download/v1.4.1/citus-1.4.1.tar.gz.asc failed: 404 Not Found
uscan die: FAIL Checking OpenPGP signature (no signature file downloaded).
Could not find any location for pg-auto-failover_1.4.1.orig.tar.*

-> debian/watch claims there is a .asc file, but the release is missing it

Problem 3, after fixing the above:

... pgcommon -lpgport -lpthread -lselinux -lxslt -lxml2 -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lrt -ldl -lm  -lpq -o pg_autoctl
/usr/bin/ld: cannot find -lgssapi_krb5
/usr/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status

-> the Makefile should be updated not to use pg_config --libs which is only useful for linking the PG server itself

[df7cb]

Oh and perhaps more importantly, if that repo should be usable for building for Debian the root directory of the repository should either be empty except for debian/, or contain the full source tree. The existing other files will prevent unpacking the orig tarball using origtargz.

[df7cb]

The referenced .asc URL in debian/watch looks fishy for pg-auto-failover:

pgpsigurlmangle=s/archive\/v(\d\S*)\.tar\.gz/releases\/download\/v$1\/citus-$1.tar.gz.asc/