Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm.sh might fail to find postgresql package even if it exists #652

Open
onurctirtir opened this issue May 20, 2021 · 1 comment
Open

rpm.sh might fail to find postgresql package even if it exists #652

onurctirtir opened this issue May 20, 2021 · 1 comment

Comments

@onurctirtir
Copy link
Member

onurctirtir commented May 20, 2021

https://github.com/citusdata/packaging/blob/gh-pages/enterprise/rpm.sh#L47..L48

Here we execute yum info to check if postgresql package is available on pgdg repo.
yum info might sometimes ask for user input to install GPG key for pgdg repo.
However, since we redirect all the output to /dev/null, users might see such false errors:

PGDG repositories don't have postgresql13-server package for your operating system
Cannot install Citus, exiting.

This is because, yum info expects user to provide 'y' to install GPG key, but we don't already show that to users.

To reproduce, simply run rpm.sh on centos7.9 docker image.

@hanefi
Copy link
Member

hanefi commented May 20, 2021

We can consider passing -y or --assume-yes option to yum info.

   -y, --assumeyes
          Automatically answer yes for all questions.

   List options are comma-separated. Command-line options override
   respective settings from configuration files.

https://man7.org/linux/man-pages/man8/yum.8.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants