Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not capitalize text #456

Open
mlutfy opened this issue Jun 19, 2020 · 1 comment
Open

Do not capitalize text #456

mlutfy opened this issue Jun 19, 2020 · 1 comment

Comments

@mlutfy
Copy link
Member

mlutfy commented Jun 19, 2020

There are a few places where Shoreditch will capitalize text using CSS.

  • This looks very very weird other languages, who do not use word caps, such as French (and most other languages that I know)
  • It's something that should be fixed either in CiviCRM core or in translations.

Example from the Administer > Customize Data and Screens > Custom Fields:

capitalize-2020-06-19_17-08

$ grep -r capitalize scss/
scss/bootstrap/overrides/style/_tables.scss:        text-transform: capitalize;
scss/bootstrap/overrides/style/_pagination.scss:    text-transform: capitalize;
scss/civicrm/campaign/pages/_campaign.scss:            text-transform: capitalize;  
scss/civicrm/campaign/pages/_survey.scss:      text-transform: capitalize;
scss/civicrm/administer/contribute/_contribute.scss:          text-transform: capitalize;
scss/civicrm/dashboard/pages/_view-dashboard.scss:        text-transform: capitalize;
scss/civicrm/contact/pages/_change-log.scss:        text-transform: capitalize;
scss/civicrm/contact/pages/_contact-discount.scss:          text-transform: capitalize;
scss/civicrm/contact/pages/_manage-groups.scss:      text-transform: capitalize;
scss/civicrm/contact/pages/_contributions.scss:            text-transform: capitalize;
scss/civicrm/contact/pages/_new-activity.scss:    text-transform: capitalize;
scss/civicrm/contact/_detail.scss:        text-transform: capitalize;
scss/civicrm/contact/_detail.scss:            text-transform: capitalize;
scss/civicrm/common/_tables.scss:    text-transform: capitalize;
scss/civicrm/common/_base.scss:      text-transform: capitalize;
scss/civicrm/common/_base.scss:    text-transform: capitalize;
scss/civicrm/common/_pager.scss:    text-transform: capitalize !important;
scss/civicrm/mixins/_expandable-table.scss:      text-transform: capitalize;
scss/civicrm/mixins/_expandable-table.scss:          text-transform: capitalize;

Happy to send a PR, but curious what your thoughts are.

@mlutfy
Copy link
Member Author

mlutfy commented Jul 17, 2020

ping @jamienovick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant