Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds WMS layer support #9

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Adds WMS layer support #9

wants to merge 2 commits into from

Conversation

n0rdlicht
Copy link
Contributor

@n0rdlicht n0rdlicht commented Feb 26, 2021 •
edited
Loading

Adding WMS support adressing #2. This is done through adding support for application/vnd.wms mediatypes as a resource.

Checklist

  • Updated JSON Schema(s) in schemas/*.json
  • Updated snapshot examples (currently only ./datapackage.json)
  • Updated readme/docs to cover changes with explanations and additional resources
  • Run tests – data validate, against existing and potential new examples
  • Request a review on this Pull Request by @n0rdlicht or other members of the @cividi team

@n0rdlicht n0rdlicht requested a review from loleg February 26, 2021 16:04
@n0rdlicht
Copy link
Contributor Author

These more map related mediatypes (also including mapbox) might be better placed inside the view.spec rather then adding empty resources. cc @loleg

@n0rdlicht n0rdlicht marked this pull request as draft February 26, 2021 16:06
@n0rdlicht n0rdlicht linked an issue Feb 26, 2021 that may be closed by this pull request
Support for WMS layer #2
Open
@n0rdlicht n0rdlicht mentioned this pull request Feb 26, 2021
Open
@loleg
Copy link
Contributor

loleg commented Mar 19, 2021

Initial observations:

  • bitbucket URLs
  • references to Gemeindescan should be replaced with links to our platform and other use cases
  • 300+ KB of geodata not needed in the spec
  • enable CI and badge for linting
  • add a section on "What is Spatial Data?" (inspiration) and what is a Spatial Data Package (maybe not quite as pendantic)
  • talk to frictionless about supporting the $schema parameter
  • "Snapshots" is a poor nickname for a standard
  • Decide whether we are a whole sub-Spec or just an extra Schema (like Table or Fiscal)
  • Propose merging this into https://github.com/frictionlessdata/specs/spatial-data-package
  • resource's added to linked to a view can be GeoJSON etc...
  • WMS is a pretty established spec, but we should clarify a few things about it, like that it is published by the Open Geospatial Consortium, XML/XSD based
  • do the WMS-view parameters have any link to SLDs or are they self-defined?
  • likewise, do we do anything with WMS metadata?
  • recommend libraries that can be used with a WMS link

@n0rdlicht n0rdlicht mentioned this pull request Mar 26, 2021
Open
@ratron
Copy link

ratron commented Jun 24, 2021 •
edited
Loading

this is covered in https://github.com/cividi/spatial-data-package-platform/issues/41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loleg loleg Awaiting requested review from loleg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for WMS layer
3 participants
@n0rdlicht @loleg @ratron