Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to add a plugin as described in the documentation #397

Open
LcsGa opened this issue Nov 10, 2023 · 6 comments
Open

Impossible to add a plugin as described in the documentation #397

LcsGa opened this issue Nov 10, 2023 · 6 comments
Labels
pending:feedback This issue is blocked by necessary feedback.

Comments

@LcsGa
Copy link

LcsGa commented Nov 10, 2023

On an angular 16 app (a pristine project as it was intended to be a POC for me to learn how ckeditor works), I tried to follow the the tutorial step by step.
Everything went smoothly, until I reached the Commands section.

The issue I'm facing is that I get this error :
image

Then I followed the documentation to fix it. Thus I modified my imports, from :
image
to :
image

Once I did so, the error was indeed gone but a new one appeared :
image

Now I don't know what other fixes I should try...

In my app I tried multipled things, from using the ckeditor angular module/component with my custom plugin, but also with a ckeditor plugin and the issue remained the same.

Then I tried to make my own ckeditor component but once again, the issue was the same !

moreover, when I try to build the project, I receive many errors on icons:

  • with esbuild
    image
  • with webpack
    image

Here is the repo of the poc

@Witoso
Copy link
Member

Witoso commented Nov 14, 2023

Hey, it's not possible to extend the predefinded builds with plugins, you need to create a custom build.

@Witoso Witoso added the pending:feedback This issue is blocked by necessary feedback. label Nov 14, 2023
@LcsGa
Copy link
Author

LcsGa commented Nov 15, 2023

Yep, that's what I tried to do after posting that message but I ended up having the same issues on a custom build...

=> I forked the "classic build" and added either already existing plugins and custom ones but the issue was with the existing ones this time, if I remember correctly (like adding CodeBlock for exemple)

@Witoso
Copy link
Member

Witoso commented Nov 16, 2023

Hmm, the tutorial uses @ckeditor/ckeditor5-editor-classic which is a different package.

Have you checked the guide for Angular?

@LcsGa
Copy link
Author

LcsGa commented Nov 16, 2023

Yes, really carefully! it didn't really help me

@Witoso
Copy link
Member

Witoso commented Nov 16, 2023

Could pack up the project for us to take a look when we have time? cc @mremiszewski

@LcsGa
Copy link
Author

LcsGa commented Nov 16, 2023

I could try yep, but not right away! I'll do it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback.
Projects
None yet
Development

No branches or pull requests

2 participants