Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 uses esbuild and its not building the custom build of ckeditor. #410

Open
waleedmughal42 opened this issue Feb 27, 2024 · 2 comments
Labels
pending:feedback This issue is blocked by necessary feedback.

Comments

@waleedmughal42
Copy link

waleedmughal42 commented Feb 27, 2024

I updated to Angular 17 and in this version angular uses
"builder": "@angular-devkit/build-angular:browser-esbuild",
to build the project and looks like its not picking up the custom-build of ckeditor in the project.
When I remove esbuild from the path of builder it works fine BUT need to know why its not working with esbuild?
Thanks

@Witoso
Copy link
Member

Witoso commented Mar 4, 2024

Could you please prepare some minimal reproducible sample for us? On Stackblitz, etc.

@Witoso Witoso added the pending:feedback This issue is blocked by necessary feedback. label Mar 4, 2024
@everttwn
Copy link

everttwn commented Jun 6, 2024

For me, the custom build had a libraryTarget of umd, I changed it to commonjs and then the editor started working again. Not really sure if this is the correct way, but it's the only thing I could come up with in the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback.
Projects
None yet
Development

No branches or pull requests

3 participants