Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.0.0 release #442

Merged
merged 9 commits into from
Sep 19, 2024
Merged

v9.0.0 release #442

merged 9 commits into from
Sep 19, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 17, 2024

Suggested merge commit message (convention)

Internal: Changelog for v9.0.0.

@Mati365
Copy link
Member Author

Mati365 commented Sep 17, 2024

@pomek Should we include changelog from alpha?

Needs to be released after @Witoso approval

@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 87ae5e3c-87fe-441d-9d6d-bd8c03ec1d29

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 017974c1-04bc-42f3-8428-986f3b83539e: 0.0%
Covered Lines: 159
Relevant Lines: 159

💛 - Coveralls

@Witoso
Copy link
Member

Witoso commented Sep 18, 2024

IMHO, we should keep the version of TS aligned with the version of TS used by the editor.

Switched compiler from TypeScript `4.x` to `5.x` to ensure compatibility with the newest CKEditor 5 packages.

The editor uses 5.0 AFAIR. Have we bumped to 5.1? I know TS is not using semver, but I'm afraid the higher we go w/o testing, the less compatibility we could have with other environments. 5.0 is already battle-tested by the editor, and I'd sleep better.

@Mati365
Copy link
Member Author

Mati365 commented Sep 18, 2024

Ok 👍 I'd try downgrade.

@Mati365
Copy link
Member Author

Mati365 commented Sep 18, 2024

@Witoso Downgraded, looks ok.

CHANGELOG.md Outdated Show resolved Hide resolved
@Mati365 Mati365 requested a review from Witoso September 18, 2024 13:07
@Witoso
Copy link
Member

Witoso commented Sep 18, 2024

We have it pinned in the editor, not sure why:

typescript": "5.0.4",

@filipsobol?

@Mati365
Copy link
Member Author

Mati365 commented Sep 18, 2024

@Witoso It's due to ~ prefix in typescript package version. It enforces the newest patch version.

@Witoso
Copy link
Member

Witoso commented Sep 18, 2024

I know, I just wonder should we pin it exactly like ckeditor5, not sure.

CHANGELOG.md Show resolved Hide resolved
@pomek
Copy link
Member

pomek commented Sep 19, 2024

Once the PR is merged, please ping @psmyrek / @martnpaneq to process the publishing process.

README.md Show resolved Hide resolved
@Mati365 Mati365 merged commit fad4dbb into master Sep 19, 2024
5 checks passed
@Mati365 Mati365 deleted the release-20240917 branch September 19, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants