Converted ckeditor5-dev-* packages to ESM #1011
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
force-pushed
the
epic/3757-esm
branch
from
9c0386f
to
54053c4
Compare
…with current CKEditor 5 tests.
…on-existing file due to an "ERR_HTTP_HEADERS_SENT" Node.js error.
…uments instead of calling `evaluate()` method, which may cause unhandled rejection due to destroyed context.
…ized arguments instead of calling `evaluate()` method, which may cause unhandled rejection due to destroyed context." This reverts commit c89444e.
… package as the latest version is not too stable.
|
I think the job is done. I do not want to revert the alpha release changes if we want to re-release it. When it comes to merging the PR, I would like to handle it once CKEditor 5 releases its next minor. |
Fix (release-tools): Passing an odd number as a value of the `concurrency` option will not crash the `executeInParallel()` function. Closes ckeditor/ckeditor5#17025.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (release-tools): Passing an odd number as a value of the
concurrencyoption will not crash theexecuteInParallel()function. Closes ckeditor/ckeditor5#17025.Other: The CKEditor 5 Dev packages are now ESM.
Other: The
@ckeditor/jsdoc-pluginspackage is no longer available as CKEditor 5 documentation uses TypeScript sources to prepare API docs. The package is no longer use by us anywhere. Hence, we decided to remove a dead code.MAJOR BREAKING CHANGE (utils): The
builds.getDllPluginWebpackConfig()function is now asynchronous now.MAJOR BREAKING CHANGE (utils): The following functions from the
bundlerobject are no longer available:createEntryFile(),getEditorConfig(),getPlugins().MAJOR BREAKING CHANGE (utils): The following functions from the
streamobject are no longer available:isTestFile(),isSourceFile(),isJSFile().MAJOR BREAKING CHANGE (utils): The
styles.themeLogger()function is no longer exposed publicly.MAJOR BREAKING CHANGE (tests): The IntelliJ Karma configuration path needs to be updated. Now, it ends with the
cjssuffix instead ofjs.MAJOR BREAKING CHANGE (docs): The package uses only TypeDoc to build the documentation. The
build()function no longer supportstypeproperty in the configuration.MAJOR BREAKING CHANGE (docs): An array of ignored files must be specified as
ignoreFilesinstead of negating a glob pattern insourceFiles.MAJOR BREAKING CHANGE: The following packages have been converted to ESM. To load them, use an
importstatement instead ofrequire().@ckeditor/ckeditor5-dev-build-tools@ckeditor/ckeditor5-dev-bump-year@ckeditor/ckeditor5-dev-ci@ckeditor/ckeditor5-dev-dependency-checker@ckeditor/ckeditor5-dev-docs@ckeditor/ckeditor5-dev-release-tools@ckeditor/ckeditor5-dev-stale-bot@ckeditor/ckeditor5-dev-tests@ckeditor/ckeditor5-dev-transifex@ckeditor/ckeditor5-dev-translations@ckeditor/ckeditor5-dev-utils@ckeditor/ckeditor5-dev-web-crawlerAdditional information
Resolve the following TODOs before merging: