Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with ckeditor5 DLL #228

Closed
pomek opened this issue Mar 20, 2021 · 2 comments
Closed

Integration with ckeditor5 DLL #228

pomek opened this issue Mar 20, 2021 · 2 comments
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Mar 20, 2021

Provide a description of the task

Currently, the CKEditor integration comes with the built-in watchdog feature into the plugin. While using the DLL version of the editor bundle, would be good to re-use existing code instead of duplicating it.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:integrations labels Mar 20, 2021
@Reinmar Reinmar added the squad:devops Issue to be handled by the Devops team. label Oct 28, 2021
@pomek
Copy link
Member Author

pomek commented Feb 26, 2023

Perhaps it would require publishing one more dist based on CKEditor 5 DLL.

@pomek
Copy link
Member Author

pomek commented Jul 25, 2023

To implement the case described in the issue, we would have to publish at least one more component that assumes the availability of watchdog on the window.CKEditor5.watchdog property.

Also, the issue will not be a thing once ckeditor/ckeditor5#13852 is resolved.

@pomek pomek closed this as completed Jul 25, 2023
@pomek pomek added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reinmar @pomek