Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Watchdog features #217

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

jnorris-cs
Copy link

Feature: The component contains the built-in watchdog feature. Address #4694

Feature: The onError() callback will be called with two arguments. The first one will be an error object (as it was before the release 3+). A second argument is an object that contains two properties:

{String} phase: 'initialization'|'runtime' - Informs when the error has occurred (during the editor/context initialization or after the initialization).

{Boolean} willEditorRestart - When true, it means that the editor component will restart itself.

The willEditorRestart property will not appear when the error has occurred in the context feature.


Additional information

I did not add support for the Context watchdog like the React adapter has. I need to understand Context watchdog better to support it.

I basically copied the changes to the react adapter to the vue adapter.

I bumped the major version of the adapter since react went from 2.x to 3.0 with same change.

I tried to follow the PR conventions as best as I understand them. Please let me know if I missed anything.

All the watchdog feature request in the project were closed as duplicates in favor of ckeditor/ckeditor5#4693 so that is why I linked an issue in a different project.

@coveralls
Copy link

coveralls commented May 13, 2022

Pull Request Test Coverage Report for Build 343

  • 50 of 50 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 333: 0.0%
Covered Lines: 73
Relevant Lines: 73

💛 - Coveralls

@pomek pomek requested a review from psmyrek May 18, 2022 06:19
@Reinmar
Copy link
Member

Reinmar commented May 18, 2022

Jaw drop :) That's a massive contribution 👏  Thank you!

@pomek
Copy link
Member

pomek commented May 18, 2022

@psmyrek, would you like to review these changes?

@psmyrek
Copy link
Contributor

psmyrek commented May 20, 2022

Hey @jnorris-cs! This is awesome, thank you for your contribution. Before merging this PR we would need also the ContextWatchdog support. Would you like to try out, or should we take over your work and finish this PR?

@jnorris-cs
Copy link
Author

Hey @jnorris-cs! This is awesome, thank you for your contribution. Before merging this PR we would need also the ContextWatchdog support. Would you like to try out, or should we take over your work and finish this PR?

@psmyrek I dont have the time to work on the ContextWatchdog anytime soon, so I would appreciate it if you finish it up. That would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants