Delay selections in should not enter infinite loop test due to changes in latest Chrome
#17113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mati365
requested review from
arkflpc,
niegowski,
pszczesniak,
illia-stv and
gorzelinski
Mati365
changed the title
should not enter infinite loop due to changes in latest Chromeshould not enter infinite loop test due to changes in latest Chrome
pszczesniak
reviewed
Sep 19, 2024
pszczesniak
approved these changes
Sep 19, 2024
pomek
pushed a commit
that referenced
this pull request
Sep 25, 2024
Tests (engine): Delay selections in `should not enter infinite loop` test due to changes in Chrome 129.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Tests (engine): Delay selections in
should not enter infinite looptest due to changes in Chrome 129.Additional information
It looks like the newest Chrome version debounces
selectionchangeevents, and I made a small delay to prevent this. In other words - firing multiple selection updates in small period of the time results in oneselectionchangeevent instead of few.Fixes:
After bumping Chrome from
128to129in test suite.edit: More likely Karma <--> Chrome driver issue, works fine in real browser.