Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide a custom Quail path #204

Open
mlewand opened this issue Jun 2, 2016 · 9 comments
Open

Allow to provide a custom Quail path #204

mlewand opened this issue Jun 2, 2016 · 9 comments

Comments

@mlewand
Copy link
Contributor

mlewand commented Jun 2, 2016

We need to modify Quail engine adapter in a way that it allows to provide a custom path to the Quail's main .js file.

One thing to keep in mind is that also all the .json files should be fetched from a given location.

This issue originated from #202.

@mlewand mlewand added this to the 1.0.1 milestone Jun 2, 2016
@Tade0 Tade0 self-assigned this Jun 3, 2016
@kattekrab
Copy link

Hi everyone - thanks so much for your work on this great piece of open source software. A11y is so important, and I'm really pleased this plugin exists.

I'm excited that we might be able to include a11ychecker in Drupal core - and resolving this issue will help make that happen!

Thanks again.
cheers
Donna

@Tade0 Tade0 self-assigned this Jun 22, 2016
@Tade0
Copy link
Contributor

Tade0 commented Jun 24, 2016

I've implemented a proposed solution: 3dbdef0.

Tests are green, manual passes, also the built version works(the plugin.js file is also significantly smaller).

Is a manual test in order here?

@mlewand
Copy link
Contributor Author

mlewand commented Jun 24, 2016

Is a manual test in order here?

Definitely yes, remember to include ticket number and target version as a tag.

@f1ames
Copy link
Contributor

f1ames commented Aug 3, 2016

@Tade0 see my comment in the PR #218 (comment).

@f1ames f1ames added review- and removed review? labels Aug 3, 2016
@Tade0 Tade0 added the review? label Aug 30, 2016
@Tade0
Copy link
Contributor

Tade0 commented Aug 30, 2016

Turns out this solution didn't work for the start.

Fixed it and re-written the tests.

@f1ames f1ames assigned f1ames and unassigned Tade0 Nov 9, 2016
@f1ames f1ames modified the milestones: 1.0.1, 1.1.1 Nov 17, 2016
@BarisW
Copy link

BarisW commented Jan 27, 2017

Just wondering, what are we waiting for now? Anything that we (the Drupal community) can do to move this forward? Thanks!

@mlewand
Copy link
Contributor Author

mlewand commented Jan 30, 2017

Hi @BarisW we're currently consumed with tasks around CKEditor 4 and CKEditor 5, and having hard time reviewing this issue. Here we need to review the issue so it's more of a CKSource task.

However you might help just checking out the solution from #218 and seeing if it works well for you, dropping comments which will be also a nice feedback for the reviewer.

@mgifford
Copy link

Quail is officially depreciated - https://github.com/quailjs/quail-core

They recommend moving to https://github.com/dequelabs/axe-core

@mgifford
Copy link

There has been some movement on this from within the Drupal community https://www.drupal.org/project/drupal/issues/2731373#comment-13264600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants