Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Maxima/Minima border effect bug #23

Open
StRigaud opened this issue Aug 5, 2022 · 0 comments · May be fixed by #24
Open

Detect Maxima/Minima border effect bug #23

StRigaud opened this issue Aug 5, 2022 · 0 comments · May be fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@StRigaud
Copy link
Member

StRigaud commented Aug 5, 2022

Issue raised here:

Fix example available here
Consist in skipping operation if coordinate is outside of buffer or if we are on the central pixel

if( all(localPos >= 0) && any(localPos != centerPos) ) {
  const float value = (float) READ_IMAGE(src, sampler, POS_src_INSTANCE(localPos.x,localPos.y,localPos.z,0)).x;
  if (value > localMax) {
    localMax = value;
    localMaxPos = localPos;
  }
} 

Need to propagate the fix to

  • detect_minima
  • detect_maxima_slice_by_slice
  • detect_minima_slice_by_slice

Need also to propagate the fix for CLIJ and pyclesperanto_prototype version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants