Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign kernel colide with the OpenCL sign function #38

Open
StRigaud opened this issue Oct 24, 2023 · 0 comments
Open

sign kernel colide with the OpenCL sign function #38

StRigaud opened this issue Oct 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@StRigaud
Copy link
Member

Generating tests for the sign kernel, i faced an overload error between clesperanto sign.cl and the OpenCL sign built-in function.

We would ideally like to rely on the built-in function but:

  • it replaces NaN with 0.0
  • CUDA function correspondent is name differently: signbit()
  • CUDA function return True/False output

Open to rename it differently than pixel_sign in future if better options are proposed.

@StRigaud StRigaud added the bug Something isn't working label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant