Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Privileged Docker Container #228

Open
GoliathLabs opened this issue Apr 4, 2022 · 2 comments
Open

Non-Privileged Docker Container #228

GoliathLabs opened this issue Apr 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@GoliathLabs
Copy link

Good day,
first of all thanks for this nice project and the work that's put into it.

I was wondering whether it would be possible change the Dockerfile so that the container doesn't run as root (as this is favoured by docker itself as best practise)?

Which parts of the project would be easy to change over to non-root and which could pose some sort of challenge?

Kind regards!

@claabs
Copy link
Owner

claabs commented Apr 4, 2022

I'm down to convert the image to non-root.

My main concern with moving to non-root user is backwards compatibility around permissions with already generated config and cookie files. I'd have to do some testing.

@claabs claabs added the enhancement New feature or request label Apr 4, 2022
@GoliathLabs
Copy link
Author

One possibility would be to display a message in the captcha solving window that this change will happen soon and that users should be aware that they need to change permissions accordingly. Maybe there is another way to run a "two-stage" container that first only changes the permissions and then in the second stages drops the privileges and runs as user 1001 or so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants