Changed the verbosity function to public #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
The change itself is fine IMO, but I'd wait for the discussion in #58 here.
epage
reviewed
Jan 23, 2023
Comment on lines
+114
to
+115
| // The raw i8 value of the combined verbosity level | ||
| pub fn verbosity(&self) -> i8 { |
There was a problem hiding this comment.
Discussion in #53 needs resolving before we can move forward with this
There was a problem hiding this comment.
(while redundant with @matthiasbeyer comment, this will help mark it as not ready for merging so we don't lose track of this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
verbosity()function to public allows the user to retrieve the raw i8 value of the flag calculation.The use case:
Users that use other logging libraries, such as tracing, can now use this library to retrieve the integer value to create their own mapping without doing a redundant and lossy type conversion from
Log::Filterback toi8.Fixes #53