Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization of accessibility #15

Open
Bubblesphere opened this issue Jul 10, 2020 · 2 comments
Open

Internationalization of accessibility #15

Bubblesphere opened this issue Jul 10, 2020 · 2 comments

Comments

@Bubblesphere
Copy link

The string.js plugin is missing labels used for accessibility.

For example, I would like to be able to dynamically change the aria-label of the fullscreen button based on the current language:
English:
<button aria-label="fullscreen"></button>
French:
<button aria-label="plein écran"></button>

@sapolio
Copy link

sapolio commented Dec 14, 2020

For exactly the same case, I upgraded my media-control plugin extension.
I rewritten the plugin template by adding an Aria attribute object in two languages (en, ru).
Of course, it would be ideal if attributes such as aria-label and title already had their translations in the strings plugin, and they would already show the hotkeys assigned to them.

@joaopaulovieira
Copy link
Member

As @sapolio described it very well, the ideal approach would be to have these translations for all elements of media control in the string plugin.

It would be necessary a PR here in the clappr-core to create these translations and another in the clappr-plugins project using these translations in the templates of each element.

Contributions are welcome (;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants