Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterise params class for '$php_conf_dir' #25

Open
grant-veepshosting opened this issue Dec 3, 2019 · 0 comments
Open

Parameterise params class for '$php_conf_dir' #25

grant-veepshosting opened this issue Dec 3, 2019 · 0 comments

Comments

@grant-veepshosting
Copy link

Given PHPv5 is end-of-life, end-of-support, we can more effectively cater to supported versions by moving the 'Debian' OS default to an override-able parameter. eg.

class newrelic::params (
  Optional[String] $php_config_dir = '/etc/php/7.4/mods-available',
){
... (unchanged most of the code)...
    'Debian': {
      $manage_repo                 = true
      $server_package_name         = 'newrelic-sysmond'
      $server_service_name         = 'newrelic-sysmond'
      $php_package_name            = 'newrelic-php5'
      $php_service_name            = 'newrelic-daemon'
      $php_default_ini_settings    = {}
      $php_default_daemon_settings = {}
      $php_extra_packages          = []
      $run_installer               = false

      case $facts['os']['distro']['codename'] {
        'xenial','stretch': { $php_conf_dir = '/etc/php/7.0/mods-available' }
        default:            { $php_conf_dir = $php_config_dir }
      }
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant