Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin off form generator to own package? #36

Open
Peter9192 opened this issue Sep 23, 2024 · 1 comment
Open

Spin off form generator to own package? #36

Peter9192 opened this issue Sep 23, 2024 · 1 comment

Comments

@Peter9192
Copy link
Member

Currently the form generator is a bit entangled with the rest of the app; I think it could be a nice package in itself. That would also make the application code more readable.

@sverhoeven
Copy link
Collaborator

At

<ObjectField
schema={ClassConfigJsonSchema}
value={experiment.reference.config}
Field={Field}
/>
we are using a JSON schema to generate a form.

The component could look something like

    <SolidJsonSchemaForm
      schema={configJsonSchema}
      values={config}
      onSubmit={handleSubmit}
    />

The properties should be typed by either infering or generating the type from the JSON schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants