Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DND Kit / React Virtual Re-renders more with DndContent #1428

Open
iamterryclark opened this issue Jun 10, 2024 · 3 comments
Open

DND Kit / React Virtual Re-renders more with DndContent #1428

iamterryclark opened this issue Jun 10, 2024 · 3 comments

Comments

@iamterryclark
Copy link

iamterryclark commented Jun 10, 2024

Hey there,

I have created a sandbox to try testing out why i am getting so many re-renders when i include DnDContext

testing the react re-render, by un-commenting the DNDWrapper I made here, with and without the context, shows very different results.

https://codesandbox.io/p/sandbox/dndkit-react-virtual-react-table-mccy7q?file=%2Fsrc%2FDNDVirtualTable.jsx%3A183%2C22

I tried to make a simple example with complex components to best mimic what I do in my application

Can anyone help as to a solution to stop all the rows rerendering?

Clicking and scrolling both will cause rerenders.

@codingedgar
Copy link

image

@iamterryclark
Copy link
Author

iamterryclark commented Jun 11, 2024

@iamterryclark
Copy link
Author

also related

#1379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants