New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triage Service exceptions: Request path contains unescaped characters (/definitions) #31

Open

grvillic opened this issue Mar 12, 2020 · 1 comment

Assignees

grvillic commented Mar 12, 2020 •

edited

Loading

TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters

requests 
| where resultCode == 500
| join (
 exceptions
 ) on operation_Id 
| extend pathPrefix = extract("/(\\w+)", 0, tostring(operation_Name))
| where outerMessage contains "ERR_UNESCAPED_CHARACTERS"

The text was updated successfully, but these errors were encountered:

jeffmendoza self-assigned this

Member

jeffmendoza commented Mar 13, 2020

This is the definitions search endpoint:
https://github.com/clearlydefined/service/blob/master/routes/definitions.js#L29
Looks like 'request' is throwing before actually trying to make a call. I think this is a clear case of missing input validation in the service. Should be a bug, not a silence

SvcRequestFailure: /definitions?pattern=apache+extras+companion%E2%80%9A%C3%B1%C2%A2+for+apache+log4j%E2%80%9A%C3%B1%C2%A2.+(log4j:apache-log4j-extras:1.1+-+http://logging.apache.org:80/log4j/companions/extras)+2.11.1&minDescribedScore=80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment