Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mysqlclient an optional dependency #250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

willprice
Copy link

MySQL shouldn't be a core dependency, I've moved it to an extra package which can be installed as pip install pattern[mysql] if users wish to install with mysql support.

@coveralls
Copy link

coveralls commented Nov 17, 2018

Coverage Status

Coverage decreased (-0.8%) to 67.472% when pulling 3b77852 on uob-vil:master into 5b85d99 on clips:master.

@gutomaia
Copy link

+1

1 similar comment
@zh0uquan
Copy link

+1

@kylemcdonald
Copy link

thank you. i tried to get pattern running on mac with this:

brew install mysql-client
pip3 install pattern

But I couldn't get it to work. This works though:

pip3 install git+https://github.com/uob-vil/pattern.git

@tuky
Copy link

tuky commented Nov 7, 2019

It would be awesome to see this happen! :-)

@Sjoerd82
Copy link

Mysql really complicates the installation, as it turns out installing the myssqlclient on a windows machine is non trivial. Any luck on removing this dependency? I've linked some related issues which can all be closed when this is resolved.

@ndvbd
Copy link

ndvbd commented Dec 5, 2022

I get:

File "/usr/lib/python3.10/zipfile.py", line 1267, in init
self._RealGetContents()
File "/usr/lib/python3.10/zipfile.py", line 1334, in _RealGetContents
raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

@sanmai-NL
Copy link

@tom-de-smedt Can you please merge this or mark the GitHub project as Archived?

@gokulnath-prabakaran-zoomrx

When will this issue be resolved?

kdmukai added a commit to readworks/pattern that referenced this pull request Aug 1, 2024
Apply upstream's PR clips#250 to "development" branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants