Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report unconsumed errors to a Manifold UnconsumedExceptionHandler? #145

Open
danielcompton opened this issue Oct 7, 2017 · 1 comment
Open

Comments

@danielcompton
Copy link
Member

I've noticed a few manifold unconsumed deferred errors bubbling up around the place. I wondered if it would be useful to be able to set an ManifoldUnconsumedExceptionHandler, with similar semantics to a Java DefaultUncaughtExceptionHandler? This could be used to report the error to exception trackers, or other sources, rather than just logging it.

I'm not intimately familiar with Manifold, so there may be some reasons why this is a bad idea?

@ztellman
Copy link
Collaborator

ztellman commented Oct 7, 2017

This seems like a reasonable request. Remember that the "unconsumed errors" are not exhaustively listed, only 1 in 1000 have the finalizer callback enabled (otherwise it's a performance issue), so it's not perfectly like the Java thread error handler, but I agree that's still useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants