-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cljdoc-analyzer can fail mysteriously #34
Comments
Same symptom has occurred for https://github.com/logicblocks/salutem for @tobyclemson. If I change cljdoc-analyzer to log full exception, for salutem I see:
And this seems like cljdoc-analyzer having no concept of a pom's So two things:
|
I don't remember how this bit of code works, but I do remember thinking that poking at the POM directly was a recipe for trouble. There are some Apache Maven APIs for dealing with POMs, maybe those can give you a "resolved version" or something. |
Thanks @SevereOverfl0w, yeah, I think you are right. |
Of note: - Unit tests also moved, entirely gutting current unit test suite here. That's not a problem, just a note. - Bumped most deps to current - Jsoup no longer directly needed here, removed. - Turfed pom.xml files, we aren't using them, so why maintain them? Can always add back if needed. - Made more use of existing babashka/fs dep to replace some of our file utility fns - The shared code brought in some pom behavior from cljdoc that looks at dependencyManagement, this addresses the specific symptoms described under cljdoc#34, but I'll leave this issue open to later address lack of logging concern. Closes cljdoc#9
This issue originated from a diagnosis session on Slack with @mccraigmccraig.
The ingestion of alia on cljdoc was failing with less than helpful error messaging.
Here's what was showing on circleci:
We managed to reproduce this failure locally and after some trial and error we noticed that alia's lein project was generating a pom with
dependencyManagement
that includedorg.clojure/clojure
. Thedependencies
section later included, as you might expect,org.clojure/clojure
without any specific version.Here's a minimal
project.clj
to illustrate. I've included an additional arbritray dependency to demonstrate a point.We'll include a dummy namespace under
src/my_stuff/api.clj
just so we have something to analyze:Steps to reproduce:
1. install locally
lein install
2. run cljdoc-analyzer
I ran from source:
result
work-around
If we put explicitly specified a version for
org.clojure/clojure
underdependencies
things analyze just fine.And rerun
lein install
Followed by cljdoc-analyzer (see step 2 above).
Then the analysis succeeds.
Notice that
version-clj/version-clj
could remain maven version free.thoughts
We don't know why the ingest failed, but we do know:
org.clojure/clojure
We can at least report the symptom, which I suspect might be "no dependencies found".
The text was updated successfully, but these errors were encountered: