Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goog.require emitted for every complete request #6

Open
thheller opened this issue Oct 7, 2019 · 3 comments
Open

goog.require emitted for every complete request #6

thheller opened this issue Oct 7, 2019 · 3 comments

Comments

@thheller
Copy link

thheller commented Oct 7, 2019

Sorry for posting an image, didn't know how to show it otherwise. Note that I pressed auto-complete a couple of times and each time a goog.require is done. Using the rebel-readline setup.

Seems like something that should only be done once?

clj-suitable

(not to mention all the other goog.addDependency stuff but I think that is the REPL doing that because of the require)

@rksm
Copy link
Member

rksm commented Oct 11, 2019

Yes, this should be done only once. For repls other than shadow-cljs this is the case, I'll add a load check for shadow in the next version.

@thheller
Copy link
Author

That example was from rebel-readline + figwheel. Didn't involve shadow-cljs at all.

@rksm
Copy link
Member

rksm commented Oct 11, 2019

OK, thanks, checked again and the loading only exist for nrepl. Will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants