:known-content-types key?

[vspinu]

I wonder if :known-content-type? check is standard enough such that a list of :known-content-types would be warranted? This would parallel :available-media-types and :media-type-available? usage.

[ordnungswidrig]

liberator.presentation.parsable-content-type? is a function that contains checks if the request content-type is parsable by parse-request-entity. So if you want to make use of parse-request-entity then set :known-content-type? to that function.

[vspinu]

This solution would also require parsing the json which I don't want to do before processable? node.

Also the doc says "parsed by the default implementation for :processable?". Following the main docs, :processable? is constant true and no parsing happens in there by default, or does it?

I basically was hoping for something like this

(defresource my-resource
  :allowed-methods [:get :post]
  :available-media-types ["application/json"]
  :known-content-types ["application/json"]
 ...

Instead of

(defresource my-resource
  :allowed-methods [:get :post]
  :available-media-types ["application/json"]
  :known-content-type? #(check-content-type % ["application/json"])

as suggested in the tutorial.

In any case, it's a small point. Feel free to close if you think it's not worth the flame.

[ordnungswidrig]

I see, and I did not get your actual intention in the beginning. What you suggest is a good idea and independent of the entity parsing I suggested.

I will happily apply a PR for :known-content-types.

[cch1]

As a new liberator user, I too found the tutorial surprisingly verbose and inefficient on this subject. Having a means of expressing the acceptability of request content types with data is a plus.