Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to enhance GetImage() to support multiple images with same imageKey #1951

Closed
sykim-etri opened this issue Dec 30, 2024 · 2 comments
Closed

Comments

@sykim-etri
Copy link
Member

현재 GetImage()는 imageKey에 대해서 하나의 결과값만 찾아서 리턴하고 있습니다.

func GetImage(nsId string, imageKey string) (model.TbImageInfo, error) {

그런데 NHNCLOUD의 경우 동일한 imageKey에 대해서 두 개의 결과(VM용, K8s용)가 있기 때문에 이미지 조회시 이슈가 발생하고 있습니다.

NHNCLOUD,KR1,b7bd50d9-bdc2-460d-8b6a-358436ae3897,Ubuntu 20.04,Ubuntu Server 20.04.6 LTS (2024.05.21),,vm
NHNCLOUD,KR1,280399f1-af96-41b7-b13b-2fae3752e97f,Ubuntu 22.04,Ubuntu Server 22.04.4 LTS (2024.05.21),,vm
NHNCLOUD,KR1,da37257b-34eb-48b2-9940-a07264c6ed23,Ubuntu 20.04,Ubuntu Server 20.04.6 LTS - Container (2024.08.20),,k8s
NHNCLOUD,KR1,7bb44280-c653-45d9-86fe-48a71aabf20d,Ubuntu 22.04,Ubuntu Server 22.04.4 LTS - Container (2024.08.20),,k8s
NHNCLOUD,KR2,b850cadf-7015-49c1-8e01-1c709289a8b8,Ubuntu 20.04,Ubuntu Server 20.04.6 LTS (2024.05.21),,vm
NHNCLOUD,KR2,84f1a13e-462e-49dd-9598-023fb2ca5d86,Ubuntu 22.04,Ubuntu Server 22.04.4 LTS (2024.05.21),,vm
NHNCLOUD,KR2,7042a062-9bf5-4bed-b850-f14d88338ee2,Ubuntu 20.04,Ubuntu Server 20.04.6 LTS - Container (2024.08.20),,k8s
NHNCLOUD,KR2,8b70ca65-5efa-4b14-8539-3f408dae205f,Ubuntu 22.04,Ubuntu Server 22.04.4 LTS - Container (2024.08.20),,k8s
NHNCLOUD,JP1,d4923746-1cd2-4d4d-9974-ccaa5c120933,Ubuntu 20.04,,,vm
NHNCLOUD,JP1,b82b6275-68f8-4ff5-8857-66c1735a22cc,Ubuntu 22.04,,,vm

관련하여 개선 방향에 대한 의견을 부탁 드립니다.
@seokho-son

@sykim-etri
Copy link
Member Author

아래 파라미터로 /ns/{nsId}/k8sClusterDynamic 호출시 GetImage()에서 K8s용 이미지 ID가 조회되어야 하는데 VM용 이미지 ID 값이 조회되어 활용되는 상황입니다.

{
  "commonImage": "nhncloud+kr1+ubuntu20.04",
  "commonSpec": "nhncloud+kr1+m2.c4m8",
  "connectionName": "nhncloud-kr1",
  "name": "k8scluster04",
  "nodeGroupName": "k8snodegroup04"
}

@seokho-son
Copy link
Member

resolved by #1952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants