'bad variable name' when launching apply.sh in tools container

[deleeuwblue]

Using iascable 2.20.1, I encountered this error when testing with Docker on Linux, using the tools container quay.io/cloudnativetoolkit/cli-tools:v1.2-v2.2.11

apply.sh: export: line 1: gitops-repo_token: bad variable name

@niklas tested the same with Mulipass and did not encounter this error.

[seansund]

This is an issue with POSIX environment variable definitions - dashes (-) are not allowed - https://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap08.html

The workaround is to update the bom.yaml so that the aliases are defined with underscores instead of dashes. This issue primarily effects sensitive variables that will be provided as environment variables.