Fixes catalog logic to ensure custom modules override base catalog #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses 'name' attribute to test module uniqueness in catalog instead of id
- Puts new modules before existing catalog modules in list so new modules are selected when there are duplicates
- Removes '?ref={version}' if the id is a 'file:' url
closes #240
Signed-off-by: Sean Sundberg <[email protected]>
seansund
force-pushed
the
240-local-module-override
branch
from
4d1d818
to
d017716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #240
Signed-off-by: Sean Sundberg [email protected]