Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing catagories dependency this will unblock Ascent building for CIO Cirrus platform #284

Open
mjperrins opened this issue Nov 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mjperrins
Copy link
Member

Consuming iascable in ascent and getting the following error


src/helpers/services.helper.ts:119:36 - error TS2339: Property 'categories' does not exist on type 'Catalog'.

119     const cats: CatExt[] = catalog.categories;
                                       ~~~~~~~~~~

src/helpers/services.helper.ts:355:17 - error TS2339: Property 'categories' does not exist on type 'Catalog'.

355         catalog.categories.forEach(category => {
                    ~~~~~~~~~~

src/helpers/services.helper.ts:355:36 - error TS7006: Parameter 'category' implicitly has an 'any' type.

355         catalog.categories.forEach(category => {
                                       ~~~~~~~~

src/helpers/services.helper.ts:356:61 - error TS7006: Parameter 'module' implicitly has an 'any' type.

356             if (category.modules) category.modules.forEach((module) => {

The fix seems to be 👍🏻

  1. Add `catagories to V2Model
export interface CatalogV2Model extends CustomResourceDefinition {
    modules: Module[];
    providers?: CatalogProviderModel[];
    aliases?: ModuleIdAlias[];
    boms: BillOfMaterialEntry[];
    categories: CatalogCategoryModel[];
}
  1. Add catagories to Catalog model
    categories: CatalogCategoryModel[];
@mjperrins mjperrins added the bug Something isn't working label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant