Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support https://github.com/Azure/go-amqp stable version #1039

Open
cx-joses opened this issue Apr 24, 2024 · 3 comments · May be fixed by #1040
Open

Support https://github.com/Azure/go-amqp stable version #1039

cx-joses opened this issue Apr 24, 2024 · 3 comments · May be fixed by #1040

Comments

@cx-joses
Copy link

Hi 😄,

Currently v2 amqp protocol is making use of Azure/go-amqp version 0.17.0. The package is already in version 1.0.5.
This is causing constraints in upgrading the cloudevents package on our side since we can only do it when cloudevents upgrades it.

Thanks
@embano1
Copy link
Member

embano1 commented Apr 24, 2024

There's been several breaking changes (as expected when moving from 0.x to 1.x) which need some work from someone familiar with the AMQP SDK. Would you be open to work on this?

@cx-joses
Copy link
Author

Hi, sure! I am currently working on this with another member and will provide a pull request.
We are in the testing phase to make sure compatibility on the functionalities!

Thanks for the quick response!

@cx-joses
Copy link
Author

@embano1 if you could review the following PR

Thanks!

@cx-joses cx-joses linked a pull request Apr 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1039 Migrate azure/go-amqp to version 1.0.5 cx-joses/sdk-go
2 participants
@embano1 @cx-joses